core/types/rollup.go: add unscaled version of EstimatedL1Size and rename EstimatedDASize #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
reviewed
Oct 31, 2024
mdehoog
reviewed
Oct 31, 2024
mdehoog
reviewed
Oct 31, 2024
roberto-bayardo
force-pushed
the
sugar-method
branch
from
95d877b to
e976625
Compare
roberto-bayardo
force-pushed
the
sugar-method
branch
from
e976625 to
b4b4744
Compare
protolambda
approved these changes
Oct 31, 2024
sebastianst
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unscaled version of EstimatedL1Size (less error prone for external users) and rename EstimatedDASize (more accurate terminology).
Tests
Additional context
Metadata