Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rvgo: Fix inverted hint writing conditional check #61

Merged
merged 2 commits into from
May 22, 2024

Conversation

pcw109550
Copy link
Contributor

@pcw109550 pcw109550 commented May 21, 2024

Description

Fix hint writing logic at vm.go. Equal bug compared with ethereum-optimism/optimism#10514.

Tests

Mirrored unit test and fuzz test.

Ensured syscall instruction is 4 bytes written, for avoiding fuzz test failure.

@pcw109550 pcw109550 force-pushed the tip/pcw109550/fix-inverted-hint-ineq branch from 6456dfa to 7973aaf Compare May 21, 2024 17:59
@pcw109550 pcw109550 requested a review from ImTei May 21, 2024 18:35
@pcw109550 pcw109550 mentioned this pull request May 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.46%. Comparing base (0bbe1c1) to head (33afd26).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   70.39%   70.46%   +0.07%     
==========================================
  Files          19       19              
  Lines        2810     2810              
==========================================
+ Hits         1978     1980       +2     
+ Misses        743      742       -1     
+ Partials       89       88       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pcw109550 pcw109550 marked this pull request as ready for review May 21, 2024 22:55
@pcw109550 pcw109550 added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit 73046f9 May 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants