Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rvgo:Add stopAtPreimage flag #56

Merged
merged 2 commits into from
Apr 18, 2024
Merged

rvgo:Add stopAtPreimage flag #56

merged 2 commits into from
Apr 18, 2024

Conversation

ImTei
Copy link
Collaborator

@ImTei ImTei commented Apr 18, 2024

Description

Add stopAtPreimage flag to run command. This implementation mirrors ethereum-optimism/optimism#9687.

This will be tested by e2e tests.

@ImTei ImTei requested a review from pcw109550 April 18, 2024 04:06
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.39%. Comparing base (f208a8c) to head (e3d1cf3).

Files Patch % Lines
rvgo/fast/instrumented.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   70.39%   70.39%           
=======================================
  Files          19       19           
  Lines        2810     2810           
=======================================
  Hits         1978     1978           
  Misses        743      743           
  Partials       89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rvgo/cmd/run.go Outdated Show resolved Hide resolved
Co-authored-by: Park Changwan <[email protected]>
@ImTei ImTei requested a review from pcw109550 April 18, 2024 19:37
@ImTei ImTei added this pull request to the merge queue Apr 18, 2024
Merged via the queue into master with commit b00ff2b Apr 18, 2024
6 checks passed
@pcw109550 pcw109550 mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants