Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rvsol: Dump post state after asterisc deployment on devnet #39

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

pcw109550
Copy link
Contributor

@pcw109550 pcw109550 commented Apr 10, 2024

Description

To run op-e2e, we need artifacts present at the test root. This patch creates L1 alloc which includes asterisc included, and asterisc contract's address.

To elaborate, we need these files from here:

	defaultL1AllocsPath := filepath.Join(root, ".devnet", "allocs-l1.json")
	defaultL1DeploymentsPath := filepath.Join(root, ".devnet", "addresses.json")
	defaultDeployConfigPath := filepath.Join(root, "packages", "contracts-bedrock", "deploy-config", "devnetL1.json")

The newly added deployment scripts create_poststate_after_deployment.sh loads L1 alloc which did not had asterisc deployed, then deploy asterisc, and dump L1 alloc to json state.

@pcw109550 pcw109550 force-pushed the tip/pcw109550/devnet-alloc-dump-with-asterisc branch from 596fa42 to 1ec428b Compare April 11, 2024 22:10
@pcw109550 pcw109550 marked this pull request as ready for review April 11, 2024 23:01
@pcw109550 pcw109550 requested review from ImTei and Inphi April 11, 2024 23:01
@ImTei ImTei mentioned this pull request Apr 11, 2024
Copy link
Collaborator

@ImTei ImTei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the new features(load & dump states) as another script, or add a flag to trigger new features? The existing deploy scripts may be used for an actual deployment to public networks

@pcw109550
Copy link
Contributor Author

Can you make the new features(load & dump states) as another script, or add a flag to trigger new features? The existing deploy scripts may be used for an actual deployment to public networks

Are we sure that we can use the existing script to deploy to the public networks? Different script may be required, like https://github.com/ethereum-optimism/optimism/tree/develop/packages/contracts-bedrock/scripts/fpac. Anyway, will implement separate method for loading and dumping states.

@pcw109550 pcw109550 requested a review from ImTei April 12, 2024 18:04
@pcw109550 pcw109550 added this pull request to the merge queue Apr 12, 2024
Merged via the queue into master with commit beef3cf Apr 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants