Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for running op-program #16

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Fix for running op-program #16

merged 6 commits into from
Feb 20, 2024

Conversation

ImTei
Copy link
Collaborator

@ImTei ImTei commented Feb 14, 2024

Description

  • Patch more symbols (referenced from Cannon)
  • Ignore unnecessary system calls
    • epoll_create1
    • epoll_ctl
    • pipe2
    • readlinkat
    • newfstatat
    • newuname
    • munmap
    • getrandom
    • TODO: is it ok?
  • Add softfloat gcflag

Test
Manually run op-program(v.1.5.1) by run command on the local devnet and op-sepolia, and it works :)

@Inphi
Copy link
Collaborator

Inphi commented Feb 14, 2024

Unnecessary syscalls can be ignored. Not just readlinkat but all syscalls not needed for derivation. The Fault Dispute Game assumes that all valid op-program derivations have valid claims. So a VM execution shouldn't fault unless either the inputs are invalid, i.e. the op-program exits with a non-zero status, or an invalid state was encountered.

@ImTei ImTei force-pushed the tip/fix-for-op-program branch from 3f2d223 to 7c82ce4 Compare February 15, 2024 02:51
@pcw109550 pcw109550 mentioned this pull request Feb 15, 2024
@ImTei ImTei force-pushed the tip/fix-for-op-program branch from 7c9d960 to c7beb8c Compare February 19, 2024 04:00
@ImTei ImTei marked this pull request as ready for review February 19, 2024 04:06
@ImTei ImTei requested review from Inphi and pcw109550 February 19, 2024 04:06
@ImTei ImTei added this pull request to the merge queue Feb 20, 2024
Merged via the queue into master with commit 181233f Feb 20, 2024
2 checks passed
"github.com/prometheus/client_model/go.init",
"github.com/prometheus/client_model/go.init.0",
"github.com/prometheus/client_model/go.init.1",
// skip flag pkg init, we need to debug arg-processing more to see why this fails
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious to know what the failure is. Does the program crash during pkg init?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, these lines are copied from Cannon 😅
So I have no idea about the details..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants