Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦙 adding ethpar mainnet #6880

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Conversation

dabitdev
Copy link
Contributor

No description provided.

Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

@dabitdev dabitdev force-pushed the ethpar-mainnet-icon-fix branch from 5b1bc1f to fa55798 Compare February 25, 2025 16:00
@dabitdev
Copy link
Contributor Author

dabitdev commented Feb 25, 2025

hey @ligi, @maintainers - I would like to support the maintenance of the repo and hope this donation can help: 0x8b0d5a018d28f407dd1123d39915e8d8703e29067e70a0d089e7a7595cc1527c

meantime, would it be possible to expedite the pull request?

@dabitdev dabitdev force-pushed the ethpar-mainnet-icon-fix branch from fa55798 to 59543aa Compare February 25, 2025 22:36
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot verify the explorer EIP3091 compatibble - can u show me the routes?

@dabitdev
Copy link
Contributor Author

I cannot verify the explorer EIP3091 compatibble - can u show me the routes?

you are right looks like ethpandaops/dora does not support EIP3091, for now I added none to the explorer standard.

@dabitdev dabitdev force-pushed the ethpar-mainnet-icon-fix branch from c1d60c8 to fd975a3 Compare February 26, 2025 09:17
@dabitdev dabitdev requested a review from ligi February 26, 2025 09:17
@dabitdev dabitdev force-pushed the ethpar-mainnet-icon-fix branch from b25bc31 to cf7bcaf Compare February 26, 2025 11:18
@dabitdev
Copy link
Contributor Author

@ligi I added ethpar testnet as well and I fixed the formatting that failed before 🙏🏻

@ligi ligi merged commit 597d7c8 into ethereum-lists:master Feb 26, 2025
5 checks passed
Copy link

PR merged - please consider contributing some funds to lists.eth

@dabitdev dabitdev deleted the ethpar-mainnet-icon-fix branch February 26, 2025 12:20
@dabitdev
Copy link
Contributor Author

dabitdev commented Feb 27, 2025

@ligi I noticed that the ethpar networks are already available—thank you!

However, the icons aren't displaying. Could you help me troubleshoot the issue?
I set up the IPFS icon using web3.storage. Here’s the link:
https://bafkreiezag3ijij32zbo3ko7xes2hafsqjhru22ab6ia35ygafc66kjb6u.ipfs.w3s.link/

Screenshot 2025-02-27 at 11 47 04 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants