Add Arthera Mainnet #4083
Merged
Add Arthera Mainnet #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ligi could you help us to get it merged by reviewing it ? |
7 tasks
2 tasks
kuzdogan
added a commit
to ethereum/sourcify
that referenced
this pull request
Jan 8, 2024
Thanks for reviewing our pull request to add a new support in Sourcify. We have followed the instructions on [how to request chain support](https://docs.sourcify.dev/docs/chain-support/) in docs. We have checked the following items before submitting our pull request for a speedy review. ethereum-lists/chains#4083 is merged but [chains.json](../blob/staging/services/server/src/chains.json) is not synchronized yet so I've temporary added an `rpc`field to be able to deploy the test contract and make the new pass. So I let you review this PR while waiting for [chains.json](../blob/staging/services/server/src/chains.json) to be automatically synchronized. Then I will remove the rpc field I added for test and I hope it should be ready. ## Checklist - [x] The branch is named as `add-chain-<chainId>`. - [ ] I haven't modified the `chains.json` file directly. - [ ] In `sourcify-chains.json` file - [x] I've set `supported: true`. - [ ] I haven't added an `rpc` field but the one in [chains.json](../blob/staging/services/server/src/chains.json) is used (if not, please explain why). - [x] I've added a test in [chain-tests.js](../blob/staging/services/server/test/chains/chain-tests.js) file. - [x] `test-new-chain` test in Circle CI is passing. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1206252769976295
masterdev2637
added a commit
to masterdev2637/sourcify
that referenced
this pull request
Jan 6, 2025
Thanks for reviewing our pull request to add a new support in Sourcify. We have followed the instructions on [how to request chain support](https://docs.sourcify.dev/docs/chain-support/) in docs. We have checked the following items before submitting our pull request for a speedy review. ethereum-lists/chains#4083 is merged but [chains.json](../blob/staging/services/server/src/chains.json) is not synchronized yet so I've temporary added an `rpc`field to be able to deploy the test contract and make the new pass. So I let you review this PR while waiting for [chains.json](../blob/staging/services/server/src/chains.json) to be automatically synchronized. Then I will remove the rpc field I added for test and I hope it should be ready. ## Checklist - [x] The branch is named as `add-chain-<chainId>`. - [ ] I haven't modified the `chains.json` file directly. - [ ] In `sourcify-chains.json` file - [x] I've set `supported: true`. - [ ] I haven't added an `rpc` field but the one in [chains.json](../blob/staging/services/server/src/chains.json) is used (if not, please explain why). - [x] I've added a test in [chain-tests.js](../blob/staging/services/server/test/chains/chain-tests.js) file. - [x] `test-new-chain` test in Circle CI is passing. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1206252769976295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/using-hardhatartheranet/arthera-docs#60