-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.6.0 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now allows parsing multiple types of chromatograms from the same file
- fixed bug affecting attachment of metadata - fixed bug in read_shimadzu_spectrum (starting one row too late) - added options for ms_format (either data.frame or list) - added retention times as names to ms_format list output
so it works again to reformat masshunter etc
fixed names of mz values in long format data
updated call_openchrom docs
install rainbow
CI: install rainbow
ethanbass
changed the title
v0.5.1 fix "mustang chemstation" v179 files (8-byte encoding)
v0.6.0
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Mustang Chemstation" seems to make 8-byte 179 files instead of 4 bytes (though this is based on a sample size of only 2 mustang files). I fixed the
read_chemstation_ch
parser to reflect this hypothesis. This should resolve issue #21 and #22