Change postgres upgrade image #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorickdowne
force-pushed
the
postgres-upgrade
branch
from
8be0970 to
a6478d7
Compare
pietjepuk2
approved these changes
Feb 11, 2025
|
Looks good! Also looks a lot simpler than the previous approach 👍 |
|
Great thank you There is one change I still want to make, which will be a separate PR: Run this in screen, if screen is available. On Debian and Ubuntu, install screen if it's not there. That would mean that this survives an SSH disconnect, which seems prudent for something that touches the slashing protection DB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pats22 image does not appear to be supported any more.
Switch to https://github.com/pgautoupgrade/docker-pgautoupgrade , which upgrades in place, and run that in "one-shot" mode
A good time to merge would be February 14th, right after the release of PostgreSQL 17.3