This repository has been archived by the owner on May 22, 2024. It is now read-only.
Add Altair fork epoch of 61650 for Pyrmont #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the Altair fork epoch for Pyrmont and updates its config to preset based format.
2 tasks
hwwhww
reviewed
Aug 4, 2021
Co-authored-by: Hsiao-Wei Wang <[email protected]>
paulhauner
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
This looks good to me, thanks for taking the effort.
We had previously converted this old-style config to the new-style, as you have done here. When we diff your changes against ours, the only differences are the fork-specific info and some newlines: sigp/lighthouse@674d594
This indicates that our translation of the old->new style was consistent with yours.
djrtwo
approved these changes
Aug 10, 2021
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Aug 10, 2021
Prater upgrading to altair at epoch 61650 - eth-clients/eth2-networks#56 also includes altair-devnet-2 support in binary
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Aug 10, 2021
Prater upgrading to altair at epoch 61650 - eth-clients/eth2-networks#56 also includes altair-devnet-2 support in binary
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Aug 11, 2021
## Issue Addressed NA ## Proposed Changes Adds the Altair fork schedule for Pyrmont, as per eth-clients/eth2-networks#56 (credits to @ajsutton). ## Additional Info - I've marked this as `do-not-merge` until the upstream PR is merged. - I've tagged this for `v1.5.0` because I expect the upstream PR to be merged soon, and I think it would be great if v1.5.0 shipped fully ready for the Pyrmont fork.
pawanjay176
pushed a commit
to pawanjay176/lighthouse
that referenced
this pull request
Aug 27, 2021
## Issue Addressed NA ## Proposed Changes Adds the Altair fork schedule for Pyrmont, as per eth-clients/eth2-networks#56 (credits to @ajsutton). ## Additional Info - I've marked this as `do-not-merge` until the upstream PR is merged. - I've tagged this for `v1.5.0` because I expect the upstream PR to be merged soon, and I think it would be great if v1.5.0 shipped fully ready for the Pyrmont fork.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the Altair fork epoch for Pyrmont and updates its config to preset based format.
Note that I've also set a custom fork version for the merge and sharding upgrades to ensure they're different from MainNet but those forks are not actually scheduled for Pyrmont yet and so those details may change again before they actually activate.