Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom request timeout setting #469

Merged
merged 2 commits into from
May 1, 2020
Merged

Custom request timeout setting #469

merged 2 commits into from
May 1, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Allow custom timeout value for networks.

How I did it

  • Add a timeout field for each network within network-config.yaml - if not present, the default value is 30 seconds
  • Set the default timeout for mainnet-fork as 120 seconds.

How to verify it

Run tests.

@codecov-io
Copy link

codecov-io commented May 1, 2020

Codecov Report

Merging #469 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #469   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files          56       56           
  Lines        6071     6071           
  Branches     1336     1336           
=======================================
  Hits         5357     5357           
  Misses        494      494           
  Partials      220      220           
Impacted Files Coverage Δ
brownie/_cli/networks.py 77.31% <100.00%> (ø)
brownie/network/main.py 87.17% <100.00%> (ø)
brownie/network/web3.py 97.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc65f98...2870b2d. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit f80d6c1 into master May 1, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the web3-timeout branch May 1, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants