Adjust compile path #427
Merged
Adjust compile path #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by modifying allow_paths to use the project root folder, interfaces may be included in projects without use of the interface_sources kwarg. this also allows more expressive error messages when importing an interface fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
In the compiler, use the project root folder as
allow_pathsrather than./contracts. This allows interface imports without using theinterface_sourceskwarg. Re: conversation on Gitter, it also ensures a more expressive error message when an interface import will not work.interface_sourceswas a solution added prior to the allowing path remappings. Now that it's possible to import from anywhere,interface_sourcesseems less useful and is a good candidate for removal in v2.0How to verify it
Run tests.