Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Moonscan API for Moonbase Alpha #1611

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

themacexpert
Copy link
Contributor

@themacexpert themacexpert commented Sep 16, 2022

What I did

Update Moonscan API for Moonbase Alpha. Previously, the Moonscan API for the Moonbeam Production mainnet was specified instead of the one for Moonbase Alpha (Testnet).

Related issue: #

How I did it

How to verify it

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

@themacexpert
Copy link
Contributor Author

@charles-cooper You mind giving this a quick review? Many thanks.

@charles-cooper
Copy link
Collaborator

i think i checked both urls and they both seem to work the same way. is the old one not working?

@themacexpert
Copy link
Contributor Author

@charles-cooper Thanks for the quick response! The old one is the correct api link for Moonbeam (production network) but needs to have the api link for the Moonbase testnet there. Currently verifying contracts for Moonbase fails but this change fixes it (I tested locally with a custom network with these specs).

@charles-cooper charles-cooper merged commit cb23164 into eth-brownie:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants