Fix: Subcalls to empty accounts #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skellet0r
changed the title
Low-level calls through the use of `raw_call` in vyper, and the `call`, `staticcall`, and `delegatecall` address members in solidity, should appear in the tx.subcalls list when directed to addresses where no contracts are deployed.
Errors appeard in the internal_transfers property due to the newly added subcall logic, this fixes it to make the test suite pass again.
Refer to geth source code for the current set of precompiled contracts. https://github.com/ethereum/go-ethereum/blob/e4270cacf4aa26875affc619dbf82ad18d06226e/core/vm/contracts.go
iamdefinitelyahuman
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Minor patch of the logic in transactions.py to handle direct calls/staticcalls/delegatecalls to empty accounts.
Fixes #1105
How I did it
Added to the if statement that determines whether a call is being made to a contract, and handled calls to the datacopy address from vyper.
How to verify it
There is a parameterized test verifying functionality in both solidity and vyper contracts.
Checklist