Feat/faucet attach 2 #269
Merged
Feat/faucet attach 2 #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rel #258 This begins implementation of the ref'd feature proposal. Currently 'ethstats' support is removed because that package relies heavily on access to a *node.Node. Eventually I want to move that packages demands to something that can be satisfied by an API instead. Date: 2020-12-21 12:16:33-06:00 Signed-off-by: meows <[email protected]>
Conflicts: cmd/faucet/faucet.go
I'm reverting the HeaderAuthorGetter interface solely to reduce diff size and complexity, both for this PR and in general. It doesn't mean I like it. Date: 2020-12-28 07:47:24-06:00 Signed-off-by: meows <[email protected]>
Work was pending resolution of ethstats reporting in conjunction with node attaching. This has been resolved conceptually by make them exclusive; you cannot activate ethstats for the faucet's target attach node (since that node can handle ethstats reporting all by itself). Date: 2020-12-28 08:05:24-06:00 Signed-off-by: meows <[email protected]>
Date: 2020-12-28 08:08:25-06:00 Signed-off-by: meows <[email protected]>
Make sure flags aren't used in impossible ways. Date: 2020-12-28 08:17:13-06:00 Signed-off-by: meows <[email protected]>
Date: 2020-12-28 08:24:18-06:00 Signed-off-by: meows <[email protected]>
Date: 2020-12-28 08:25:09-06:00 Signed-off-by: meows <[email protected]>
Date: 2020-12-28 08:37:41-06:00 Signed-off-by: meows <[email protected]>
meowsbits
commented
Dec 28, 2020
Date: 2020-12-28 10:10:51-06:00 Signed-off-by: meows <[email protected]>
Faucet behavior previously effectively demanded user configuration of bootnodes manually to enable peering. This disables NoDiscovery, thus enabling discovery. Date: 2020-12-28 10:19:05-06:00 Signed-off-by: meows <[email protected]>
Date: 2020-12-28 10:22:20-06:00 Signed-off-by: meows <[email protected]>
As noted in the comment on line 310, when attaching to a remote client it may be that the API says that chain id is 0 when the client is not yet synced past the EIP155 activation block height. Requesting and switching on the genesis block hash fixes this issue except for the foundation/classic corner case (same genesis, different chain ids). Date: 2020-12-29 05:14:04-06:00 Signed-off-by: meows <[email protected]>
This value would be useful and necessary only if the target client were unsynced past the EIP155 activation height. ChainID is used to disambiguate ETH/ETC chains. Date: 2020-12-29 05:30:04-06:00 Signed-off-by: meows <[email protected]>
iquidus
approved these changes
Dec 30, 2020
| @@ -629,7 +725,15 @@ func (f *faucet) apiHandler(w http.ResponseWriter, r *http.Request) { | |||
| amount = new(big.Int).Div(amount, new(big.Int).Exp(big.NewInt(2), big.NewInt(int64(msg.Tier)), nil)) | |||
|
|
|||
| tx := types.NewTransaction(f.nonce+uint64(len(f.reqs)), address, amount, 21000, f.price, nil) | |||
| signed, err := f.keystore.SignTx(f.account, tx, f.config.GetChainID()) | |||
|
|
|||
| // FIXME(meowsbits): Getting the chain id more than once is redundant and can be optimized. | |||
There was a problem hiding this comment.
is there a solution for this in mind?
There was a problem hiding this comment.
Probably there are at least a few ways of handling it. One that comes first to mind is to add a field on faucet, eg. faucet.chainID since we know that once it's set to a nonzero value it won't change, and the faucet is only designed to handle a single network. But IMO this is a nice-to-have optimization since the request will only be made for each faucet transaction... which isn't more than can be expected for a "standard" transaction-making program (at least it's not getting called at every block or anything like that). Because of this I'm OK pushing to a later optimization if need/desire calls for it.
Merged
ziogaschr
reviewed
Jan 4, 2021
This was referenced Jan 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #259.
Creates
-attachflag allowing the faucet program to not run it's own client, instead attaching to an existing one via JSONRPC. Target client API needs to haveethandnetAPI modules exposed.(c99ed45) Disables
NoDiscoverysetting for managed client P2P configuration. Allowing discovery allows the faucet to not rely exclusively on manually configured bootnodes. Left commented because this differs from upstream... and I'm not sure at this point what the rationale was for disabling p2p discovery in the first place.