Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added WG etcd operator community meetings to community section #899

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

danish9039
Copy link
Contributor

resolves issue #896

WG etcd operator community meetings to community section

Signed-off-by: danish siddiqui <[email protected]>
@k8s-ci-robot
Copy link

Hi @danish9039. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @danish9039, a few suggestions below 🙏🏻

Signed-off-by: danish siddiqui <[email protected]>
@ivanvc
Copy link
Member

ivanvc commented Sep 20, 2024

/ok-to-test

Signed-off-by: danish siddiqui <[email protected]>
@ivanvc ivanvc requested a review from jmhbnz September 20, 2024 18:24
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @danish9039, for your first contribution!
I think we just need a squash of the commits.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but a nit - In both the sections on this same page Community meetings & Issue triage and Robustness tests the meeting time is mentioned as below:
... AM Pacific Time

We may want to use the same format instead of using ... a.m. PT.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Happy for the AM formatting to be addressed as a follow-up.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danish9039, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit c393b04 into etcd-io:main Sep 26, 2024
6 checks passed
@ivanvc ivanvc mentioned this pull request Sep 26, 2024
NotAwar pushed a commit to NotAwar/website that referenced this pull request Feb 27, 2025
 added WG etcd operator community meetings to community section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants