Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot config to ensure allow is an array #868

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Jun 29, 2024

My last pr didn't quite get the dependabot config right, allow is supposed to be an array, refer: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow

@jmhbnz jmhbnz changed the title Fix dependabot config to ensure allow is an array. Fix dependabot config to ensure allow is an array Jun 29, 2024
@jmhbnz jmhbnz marked this pull request as ready for review June 29, 2024 18:48
@jmhbnz jmhbnz requested review from ivanvc and spzala June 29, 2024 18:49
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, YAML's tricky sometimes :) Thanks for fixing it @jmhbnz

@spzala spzala merged commit 9ecbbf4 into etcd-io:main Jun 29, 2024
5 checks passed
@ivanvc
Copy link
Member

ivanvc commented Jun 29, 2024

It sounds like linting YAMLs would be a good improvement. Running yamllint against the old dependabot.yml file yields:

.github/dependabot.yml
  9:9       error    wrong indentation: expected 6 but found 8  (indentation)
  10:9      error    duplication of key "dependency-type" in mapping  (key-duplicates)

NotAwar pushed a commit to NotAwar/website that referenced this pull request Feb 27, 2025
Fix dependabot config to ensure allow is an array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants