integration: add TestV3WatchMultipleStreams #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| streams[i] = wStream | ||
| } | ||
|
|
||
| for i := range streams { |
There was a problem hiding this comment.
for _, wStream := ... ?
| // now Recv should block because there is no more events coming | ||
| for i := range streams { | ||
| wStream := streams[i] | ||
| rok, nr := WaitResponse(wStream, 1*time.Second) |
There was a problem hiding this comment.
move to goroutine above so waits are concurrent?
| t.Fatalf("wAPI.Watch error: %v", err) | ||
| wStream, wErr := wAPI.Watch(context.TODO()) | ||
| if wErr != nil { | ||
| t.Fatalf("wAPI.Watch error: %v", wErr) |
There was a problem hiding this comment.
fixing this based on go tool -shadow.
|
@heyitsanthony Just addressed. PTAL. Thanks! |
|
lgtm |
|
Thanks |
gyuho
added a commit
that referenced
this pull request
Jan 19, 2016
integration: add TestV3WatchMultipleStreams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #4216.