integration: watch cancel test #4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }{ | ||
| // one key, one put, one watch, one cancellation | ||
| { | ||
| []*pb.PutRequest{ |
There was a problem hiding this comment.
let's make these requests one line when possible to improve readability.
gyuho
force-pushed
the
watch_cancel_test
branch
from
db95995 to
f37bc72
Compare
|
|
||
| wcreatedN := 0 | ||
| for _, wreq := range tt.wreqs { | ||
| if wreq == nil { |
There was a problem hiding this comment.
well... why do we want to put a nil into wreqs?
There was a problem hiding this comment.
I set up the tests, with each put, watch request, watch response having exact the same number of elements
so that I can run each action by index and match event by index. Do you have any suggestion? I need nil to fill
those slice. And if wreq is nil it doesn't send watch request.
gyuho
force-pushed
the
watch_cancel_test
branch
2 times, most recently
from
fc9ca17 to
6982a0c
Compare
|
@xiang90 PTAL. Just simplified. Thanks, |
| t.Fatalf("wAPI.Watch error: %v", err) | ||
| } | ||
|
|
||
| // send create WatchRequest |
gyuho
force-pushed
the
watch_cancel_test
branch
from
6982a0c to
64ffe60
Compare
|
@xiang90 Just fixed comments. Thanks, |
|
LGTM |
|
Test all passed. I will quickly fix the govet shadow issue in the same commit and merge after second CI passes. |
gyuho
force-pushed
the
watch_cancel_test
branch
from
64ffe60 to
2535509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #4216.