Support run as windows service #3410
Conversation
1. `sc create etcd binPath= "C:\etcd\etcd.exe -data-dir=C:\etcd\etcd.service.data"` 2. `net start etcd` 3. `net stop etcd` 4. `sc delete etcd`
|
@chai2010 Can you fix the issue reported by go vet? @judwhite @cloudtrends Can you please take a look? |
|
I'm very interested in this, just wanted to give a heads up my response may be delayed due to other commitments. I will try it out locally and follow up within the week. |
|
|
main_windows.go
Outdated
| } | ||
|
|
||
| func (m *etcdService) Execute(args []string, r <-chan svc.ChangeRequest, changes chan<- svc.Status) (ssec bool, errno uint32) { | ||
| const cmdsAccepted = svc.AcceptStop | svc.AcceptShutdown | svc.AcceptPauseAndContinue |
There was a problem hiding this comment.
Suggest removing svc.AcceptPauseAndContinue
|
@chai2010 Are you still interested in this? If you're too busy I can see it through and find another reviewer to help us out. |
|
@judwhite sorry for this delayed comments. I do some other work these days. |
|
Any updates on this? |
|
Sort of, I'm working with the authors of NSQ on a similar change. We're working out final details and I'd like to reference the work there once it's merged. The PR is old, but day jobs, and holidays. We're picking it back up and just spoke today about it. nsqio/nsq#676 |
|
@judwhite great, thanks for the update, if there is anything I can do to help just let me know |
|
This landed in nsqio/nsq#718 @chai2010 @xiang90 @hminaya what do you think of this approach? |
|
@judwhite sounds good to me. |
gyuho
force-pushed
the
master
branch
2 times, most recently
from
44ca396 to
4301f49
Compare
|
Closing due to inactivity. Please create a new one if needed. |
sc create etcd binPath= "C:\etcd\etcd.exe -data-dir=C:\etcd\etcd.service.data"net start etcdnet stop etcdsc delete etcdNotes: Add "golang.org/x/sys/windows/svc" to vendor.