Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problematic new solution] Fix race condition (also a regression of the PR 19139) #19256

Closed
wants to merge 1 commit into from

Ensure all goroutines created by StartEtcd to complete before closing…

d12c2cc
Select commit
Loading
Failed to load commit list.
Closed

[Problematic new solution] Fix race condition (also a regression of the PR 19139) #19256

Ensure all goroutines created by StartEtcd to complete before closing…
d12c2cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 22, 2025 in 1s

68.80% (-0.05%) compared to c9045d6

View this Pull Request on Codecov

68.80% (-0.05%) compared to c9045d6

Details

Codecov Report

Attention: Patch coverage is 74.07407% with 14 lines in your changes missing coverage. Please review.

Project coverage is 68.80%. Comparing base (c9045d6) to head (d12c2cc).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
server/embed/etcd.go 62.06% 11 Missing ⚠️
server/embed/serve.go 88.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/serve.go 59.52% <88.00%> (+1.72%) ⬆️
server/embed/etcd.go 75.51% <62.06%> (-0.36%) ⬇️

... and 12 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19256      +/-   ##
==========================================
- Coverage   68.85%   68.80%   -0.05%     
==========================================
  Files         420      420              
  Lines       35655    35675      +20     
==========================================
- Hits        24551    24547       -4     
- Misses       9683     9705      +22     
- Partials     1421     1423       +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9045d6...d12c2cc. Read the comment docs.