-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add downgrade cancellation e2e tests #19252
base: main
Are you sure you want to change the base?
Add downgrade cancellation e2e tests #19252
Conversation
Signed-off-by: Chun-Hung Tseng <[email protected]> Co-authored-by: Benjamin Wang <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henrybear327 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #19252 +/- ##
=======================================
Coverage 68.77% 68.78%
=======================================
Files 420 420
Lines 35649 35649
=======================================
+ Hits 24518 24521 +3
+ Misses 9705 9699 -6
- Partials 1426 1429 +3 Continue to review full report in Codecov by Sentry.
|
ret[i] = &version.Versions{ | ||
Cluster: ver.String(), | ||
Server: e2e.OffsetMinor(ver, 1).String(), | ||
Storage: "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will continue to investigate this tomorrow
Part 2 of the e2e test - downgrade cancellation is called after the cluster has been partially downgraded
This PR is currently based on #19244, thus, it's put in draft mode for now.
Reference: #17976
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.