Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: fix comment to match function name #17433

Merged
merged 1 commit into from
Feb 16, 2024
Merged

server: fix comment to match function name #17433

merged 1 commit into from
Feb 16, 2024

Conversation

vivekpatani
Copy link
Contributor

@vivekpatani vivekpatani commented Feb 16, 2024 •
edited
Loading

@k8s-ci-robot
Copy link

Hi @vivekpatani. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vivekpatani
server: fix comment to match function name
b9b4f1b 
- goword checks fail if function name mismatches with comment
- etcd-io#17400

Signed-off-by: vivekpatani <[email protected]>
jmhbnz
jmhbnz approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vivekpatani added a commit to vivekpatani/etcd that referenced this pull request Feb 16, 2024
@vivekpatani
*: add test-smoke to the pipeline and update test-smoke
6f06355 
- add test-smoke to the tests.yaml pipeline
- add bom and dep to the test-smoke definition
- etcd-io#17400
- etcd-io#17401
- wait for etcd-io#17433 to merge
- wait for etcd-io#17434 to merge

Signed-off-by: vivekpatani <[email protected]>
@vivekpatani vivekpatani mentioned this pull request Feb 16, 2024
Merged
@vivekpatani
Copy link
Contributor Author

@jmhbnz can you please retest this? Integration tests shouldn't fail due to this change (at least not from the looks of the tiny change). Thanks.

@jmhbnz
Copy link
Member

jmhbnz commented Feb 16, 2024

/retest

@ahrtr ahrtr merged commit c6e9488 into etcd-io:release-3.5 Feb 16, 2024
15 checks passed
@vivekpatani vivekpatani deleted the fix-goword branch February 16, 2024 18:00
@vivekpatani vivekpatani mentioned this pull request Feb 16, 2024
Closed
4 tasks
vivekpatani added a commit to vivekpatani/etcd that referenced this pull request Feb 16, 2024
@vivekpatani
*: add test-smoke to the pipeline and update test-smoke
763bf89 
- add test-smoke to the tests.yaml pipeline
- add bom and dep to the test-smoke definition
- etcd-io#17400
- etcd-io#17401
- wait for etcd-io#17433 to merge
- wait for etcd-io#17434 to merge

Signed-off-by: vivekpatani <[email protected]>
vivekpatani added a commit to vivekpatani/etcd that referenced this pull request Feb 17, 2024
@vivekpatani
*: add test-smoke to the pipeline and update test-smoke
9635525 
- add test-smoke to the tests.yaml pipeline
- add bom and dep to the test-smoke definition
- etcd-io#17400
- etcd-io#17401
- wait for etcd-io#17433 to merge
- wait for etcd-io#17434 to merge

Signed-off-by: vivekpatani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
ok-to-test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivekpatani @k8s-ci-robot @jmhbnz @ahrtr