test: support regular expression matching on the response #16472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
force-pushed
the
expr_expect_20230825
branch
2 times, most recently
from
14ef651 to
8c60e12
Compare
fuweid
reviewed
Aug 25, 2023
Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
expr_expect_20230825
branch
from
8c60e12 to
7d95c68
Compare
|
ping @wenjiaswe @serathius @spzala PTAL when you get free cycle. This should be a simple and straightforward change. I expect this PR to be merged asap, otherwise it will definitely conflict with other PRs. |
wenjiaswe
reviewed
Aug 25, 2023
Signed-off-by: Benjamin Wang <[email protected]>
|
lgtm |
|
thx @wenjiaswe for the quick review. Also thx @jmhbnz and @fuweid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only support exact string match on the response (e.g. curl response, and process output). But in some cases, the response may not be a fixed string. One example is discussed in #16454, there may be random spaces in the grpc-gateway v2 response.
So we need to support match the response based on a regular expression.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.