test: fix anti-pattern naming problem in config.ClusterConfig #14629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clark <[email protected]>
clement2026
force-pushed
the
fix-anti-pattern-naming
branch
from
b4c332a to
08284c5
Compare
serathius
approved these changes
Oct 26, 2022
ahrtr
reviewed
Oct 26, 2022
|
|
||
| func NewClusterConfig(clusterSize int, opts ...ClusterOption) ClusterConfig { | ||
| c := defaultClusterConfig() | ||
| c.ClusterSize = clusterSize |
There was a problem hiding this comment.
Minor comment: can we add a ClusterOption interface for ClusterSize as well? The benefit is that we don't need to provide a clusterSize if we use the default value.
It isn't a big deal. Feel free to think/discuss this in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the anti-pattern naming problem(see #14389), such as
DisableStrictReconfigCheck(written by me🤣).As far as I see, at least 4 structs have this problem:
This PR only tries to fix
(2)config.ClusterConfig.(3)e2e.EtcdProcessClusterConfigand(4)integration.ClusterConfigwill be fixed after this PR.This PR changed
(2)config.ClusterConfigwith the Functional Options Pattern. I’m not sure if this is a proper solution. Please take a look and give some suggestions.