Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lineariziable range request in TestKVGet #13957

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Apr 18, 2022

Fix the following test failure.


$ cd tests/common/
$ go test --tags integration -run TestKVPut -v
    logger.go:130: 2022-04-18T08:58:29.561+0800	INFO	m1	trace[1615401671] put	{"member": "m1", "detail": "{key:foo; req_size:10; response_revision:2; }", "duration": "136.483949ms", "start": "2022-04-18T08:58:29.425+0800", "end": "2022-04-18T08:58:29.561+0800", "steps": ["trace[1615401671] 'process raft request'  (duration: 75.406328ms)", "trace[1615401671] 'marshal mvccpb.KeyValue'  (duration: 60.998853ms)"], "step_count": 2}
    kv_test.go:71: Unexpected lenth of response, got 0
    cluster.go:1368: ========= Cluster termination started =====================
panic: runtime error: index out of range [0] with length 0

goroutine 708 [running]:
go.etcd.io/etcd/tests/v3/common.TestKVPut.func1.1()
	/Users/wachao/go/src/github.com/ahrtr/etcd/tests/common/kv_test.go:73 +0x45f
go.etcd.io/etcd/tests/v3/framework/testutils.ExecuteWithTimeout.func1()
	/Users/wachao/go/src/github.com/ahrtr/etcd/tests/framework/testutils/execute.go:29 +0x5b
created by go.etcd.io/etcd/tests/v3/framework/testutils.ExecuteWithTimeout
	/Users/wachao/go/src/github.com/ahrtr/etcd/tests/framework/testutils/execute.go:27 +0xaf
exit status 2
FAIL	go.etcd.io/etcd/tests/v3/common	2.506s

Note: use command below can reproduce this issue more easily (without the -v),

$ go test --tags integration -run TestKVPut

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #13957 (842fed5) into main (8149191) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13957      +/-   ##
==========================================
- Coverage   72.61%   72.50%   -0.11%     
==========================================
  Files         469      469              
  Lines       38414    38414              
==========================================
- Hits        27895    27853      -42     
- Misses       8745     8781      +36     
- Partials     1774     1780       +6     
Flag Coverage Δ
all 72.50% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
client/v3/leasing/cache.go 87.77% <0.00%> (-3.89%) ⬇️
client/pkg/v3/testutil/recorder.go 76.27% <0.00%> (-3.39%) ⬇️
client/v3/leasing/txn.go 88.09% <0.00%> (-3.18%) ⬇️
client/pkg/v3/transport/listener.go 57.18% <0.00%> (-2.40%) ⬇️
server/etcdserver/util.go 86.17% <0.00%> (-2.13%) ⬇️
server/etcdserver/api/v3rpc/watch.go 86.57% <0.00%> (-1.35%) ⬇️
server/proxy/grpcproxy/watch.go 95.37% <0.00%> (-1.16%) ⬇️
server/storage/mvcc/kvstore_txn.go 75.27% <0.00%> (-1.10%) ⬇️
server/etcdserver/api/v3rpc/interceptor.go 76.56% <0.00%> (-1.05%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8149191...842fed5. Read the comment docs.

@ptabor ptabor merged commit 93c54b8 into etcd-io:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants