Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add tests for snapshot compatibility and recovery between versions #13756

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

serathius
Copy link
Member

@serathius serathius commented Mar 2, 2022

When working on removing V2 store, this tests were critical in finding bugs. They are required that removing v2store will not break backward compatibility.
cc @ptabor @spzala @ahrtr

@codecov-commenter
Copy link

Codecov Report

Merging #13756 (6f1e1da) into main (ae57fe5) will decrease coverage by 0.12%.
The diff coverage is 92.00%.

❗ Current head 6f1e1da differs from pull request most recent head 3ffa253. Consider uploading reports for the commit 3ffa253 to get more accurate results

@@            Coverage Diff             @@
##             main   #13756      +/-   ##
==========================================
- Coverage   72.45%   72.33%   -0.13%     
==========================================
  Files         469      469              
  Lines       38276    38283       +7     
==========================================
- Hits        27733    27692      -41     
- Misses       8756     8806      +50     
+ Partials     1787     1785       -2     
Flag Coverage Δ
all 72.33% <92.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
etcdutl/etcdutl/backup_command.go 9.94% <0.00%> (ø)
etcdutl/etcdutl/migrate_command.go 75.00% <88.88%> (ø)
etcdutl/etcdutl/defrag_command.go 78.78% <100.00%> (ø)
etcdutl/snapshot/v3_snapshot.go 66.10% <100.00%> (ø)
server/lease/lessor.go 88.80% <100.00%> (ø)
server/storage/backend.go 62.74% <100.00%> (ø)
server/storage/backend/backend.go 83.71% <100.00%> (-0.06%) ⬇️
server/storage/backend/testing/betesting.go 87.50% <100.00%> (ø)
server/verify/verify.go 48.33% <100.00%> (ø)
server/proxy/grpcproxy/auth.go 88.67% <0.00%> (-11.33%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae57fe5...3ffa253. Read the comment docs.

@serathius
Copy link
Member Author

cc @ptabor

@serathius serathius merged commit 05e6527 into etcd-io:main Apr 8, 2022
@serathius serathius mentioned this pull request May 2, 2023
31 tasks
@serathius serathius deleted the test-snapshot branch June 15, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants