Refactor common code from etcdctl (v2,v3) to pkg/corbautl. #12969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparation for etcdutl split.
lilic
reviewed
May 14, 2021
| @@ -12,13 +12,11 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package command | |||
| package cobrautl | |||
There was a problem hiding this comment.
Non blocking suggestion: Are any of these exit codes really specific to cobra? This is more like exit util helper package if I understand correctly?
There was a problem hiding this comment.
They are not indeed. But all our 'binaries' run on cobra as a app-framework. I didn't found it worth to split completely.
gyuho
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for etcdutl split.