Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger unit test workflow on pull_requests #12936

Merged
merged 1 commit into from
May 10, 2021

Conversation

serathius
Copy link
Member

@gyuho
Copy link
Contributor

gyuho commented May 10, 2021

Nice! Can we remove Travis CI now?

@serathius
Copy link
Member Author

We have data from 7 runs https://github.com/etcd-io/etcd/actions/workflows/unit-tests.yaml

  • 1/7 linux-amd64-integration-4-cpu runs failed
  • 1/7 linux-amd64-functional failed
    As those run only on merge they are just pure flakes.

@gyuho
Do we see similar flakes on Travis runs? Just making sure that we don't introduce degradation here.

@gyuho
Copy link
Contributor

gyuho commented May 10, 2021

Do we see similar flakes on Travis runs? Just making sure that we don't introduce degradation here.

Rerunning

@ptabor
Copy link
Contributor

ptabor commented May 10, 2021

I would consider keeping Coverage on travis, and removing rest from Travis soon (e.g. PR today, merged tomorrow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants