etcdserver: add more detailed traces on linearized reading #12335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangcong
reviewed
Sep 25, 2020
| @@ -775,6 +778,7 @@ func (s *EtcdServer) linearizableReadLoop() { | |||
| if !done { | |||
| continue | |||
| } | |||
| trace.Step("read index received") | |||
There was a problem hiding this comment.
can we add following fields to improve observability?
trace.AddField(traceutil.Field{Key: "appliedIndex", Value: s.getAppliedIndex})
trace.AddField(traceutil.Field{Key: "readStateIndex", Value: rs.Index})
There was a problem hiding this comment.
ci is failed. https://travis-ci.com/github/etcd-io/etcd/jobs/391026189
PierreZ
force-pushed
the
dev/11884/tracing/read_entries
branch
from
0fe5424 to
a9ad9a9
Compare
tangcong
reviewed
Sep 25, 2020
etcdserver/v3_server.go
Outdated
| @@ -715,6 +716,9 @@ func (s *EtcdServer) linearizableReadLoop() { | |||
| return | |||
| } | |||
|
|
|||
| // as a single loop is can unlock multiple reads, it is not very useful | |||
| // to propagate the trace from Txn or Range. | |||
| trace := traceutil.New("linearizableReadLoop", s.lg) | |||
There was a problem hiding this comment.
lg should be s.getLogger().
To improve debuggability of `agreement among raft nodes before linearized reading`, we added some tracing inside `linearizableReadLoop`. This will allow us to know the timing of `s.r.ReadIndex` vs `s.applyWait.Wait(rs.Index)`.
PierreZ
force-pushed
the
dev/11884/tracing/read_entries
branch
from
a9ad9a9 to
19129ef
Compare
|
lgtm. thanks @PierreZ |
This was referenced Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #11884
Why
To improve debuggability of
agreement among raft nodes before linearized reading, we added some tracing insidelinearizableReadLoop.This will allow us to know the timing of
s.r.ReadIndexvss.applyWait.Wait(rs.Index).Results
The patch has been deployed on clusters running v3.4.9, here's some traces:
{ "level": "info", "ts": "2020-09-22T12:54:01.021Z", "caller": "traceutil/trace.go:152", "msg": "trace[2138445431] linearizableReadLoop", "detail": "", "duration": "855.447896ms", "start": "2020-09-22T12:54:00.166Z", "end": "2020-09-22T12:54:01.021Z", "steps": [ "trace[2138445431] read index received (duration: 824.408µs)", "trace[2138445431] applied index is now lower than readState.Index (duration: 854.622058ms)" ] }