-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdserver: prune revisions before send backend readTx when rangekeys #12305
Closed
xrmzju
wants to merge
1
commit into
etcd-io:master
from
xrmzju:improve-range-performance-with-filterd-revision
Closed
etcdserver: prune revisions before send backend readTx when rangekeys #12305
xrmzju
wants to merge
1
commit into
etcd-io:master
from
xrmzju:improve-range-performance-with-filterd-revision
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this improves performance tremendously for request WithLastRev() or WithFristRev() option when key range is big [root@edd2693ca788 /]# time ./etcdctl get --prefix=true /default/ --last-rev=true --keys-only -wjson --command-timeout=60s
{"header":{"cluster_id":11136150232382961551,"member_id":4898650950304686290,"revision":1337662,"raft_term":23},"kvs":[{"key":"L2RlZmF1bHQvQjFDVFl5d0ZxSVFpb2ZHMXBPcXpiVGtBbWVKTFQyZGc=","create_revision":1337662,"mod_revision":1337662,"version":1}],"more":true,"count":1317250}
real 0m35.135s
user 0m0.031s
sys 0m0.022s with this pr
|
8f7987f
to
6049144
Compare
i don't see why the ci build failed ,can somebody help me... |
6049144
to
fcbd007
Compare
cfc4n
reviewed
Sep 16, 2020
4df803c
to
3378fa0
Compare
3378fa0
to
6648f35
Compare
6648f35
to
d7c3bd2
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue 12301