clientv3: fix retry/streamer error message #11313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11313 +/- ##
==========================================
+ Coverage 64.18% 64.31% +0.13%
==========================================
Files 403 403
Lines 37966 37968 +2
==========================================
+ Hits 24369 24421 +52
+ Misses 11954 11905 -49
+ Partials 1643 1642 -1
Continue to review full report at Codecov.
|
jingyih
reviewed
Oct 31, 2019
Signed-off-by: Gyuho Lee <[email protected]>
gyuho
commented
Oct 31, 2019
| // We start off from attempt 1, because zeroth was already made on normal SendMsg(). | ||
| for attempt := uint(1); attempt < s.callOpts.max; attempt++ { | ||
| if err := waitRetryBackoff(s.ctx, attempt, s.callOpts); err != nil { | ||
| return err | ||
| } | ||
| newStream, err := s.reestablishStreamAndResendBuffer(s.ctx) | ||
| if err != nil { | ||
| // TODO(mwitkow): Maybe dial and transport errors should be retriable? | ||
| return err | ||
| s.client.lg.Error("failed reestablishStreamAndResendBuffer", zap.Error(err)) |
There was a problem hiding this comment.
@jingyih It's a different call.
streamer above is only for creating a stream.
Here, it's handling the error for streamer and resending the buffers.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11310.
serverStreamingRetryingStreamis doing all retries.Logging should be moved there.
/cc @jpbetz @jingyih