Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functiona: fix flaky tests #11006

Merged
merged 3 commits into from
Aug 8, 2019
Merged

functiona: fix flaky tests #11006

merged 3 commits into from
Aug 8, 2019

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 7, 2019

SIGQUIT_AND_REMOVE_ONE_FOLLOWER_UNTIL_TRIGGER_SNAPSHOT has been flaky.

Lower snapshot count for slow computes (e.g. CI), and be more generous about error counts during NO_FAIL_WITH_STRESS.

Address #10979.

@gyuho gyuho force-pushed the functional branch 2 times, most recently from 76cec2f to ca9857b Compare August 8, 2019 00:16
@etcd-io etcd-io deleted a comment from codecov-io Aug 8, 2019
@gyuho gyuho requested a review from wenjiaswe August 8, 2019 00:36
@gyuho gyuho changed the title functional.yaml: try lower snapshot count for flaky tests functiona: fix flaky tests Aug 8, 2019
Copy link
Contributor

@wenjiaswe wenjiaswe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thanks!

@gyuho gyuho merged commit 1c65af7 into etcd-io:master Aug 8, 2019
@gyuho gyuho deleted the functional branch August 8, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants