Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update gRPC to latest #10990

Merged
merged 2 commits into from
Aug 6, 2019
Merged

vendor: update gRPC to latest #10990

merged 2 commits into from
Aug 6, 2019

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 6, 2019

For now, can you use the released version? It doesn't have the change (9771422) that caused the problem

grpc/grpc-go#2952 (comment)

Address #10979

@codecov-io
Copy link

codecov-io commented Aug 6, 2019

Codecov Report

Merging #10990 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10990      +/-   ##
==========================================
- Coverage   63.81%   63.77%   -0.04%     
==========================================
  Files         401      401              
  Lines       37551    37551              
==========================================
- Hits        23962    23949      -13     
- Misses      11980    11981       +1     
- Partials     1609     1621      +12
Impacted Files Coverage Δ
clientv3/ordering/kv.go 8.82% <0%> (-76.48%) ⬇️
client/client.go 48.03% <0%> (-35.95%) ⬇️
client/keys.go 72.86% <0%> (-18.6%) ⬇️
proxy/httpproxy/director.go 61.42% <0%> (-18.58%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
etcdserver/api/v3rpc/lease.go 67.04% <0%> (-7.96%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
clientv3/leasing/util.go 95% <0%> (-3.34%) ⬇️
lease/leasehttp/http.go 64.23% <0%> (-1.46%) ⬇️
etcdserver/api/v3rpc/watch.go 80.06% <0%> (-1.31%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a00a3...017b6c4. Read the comment docs.

@gyuho gyuho added the WIP label Aug 6, 2019
@gyuho
Copy link
Contributor Author

gyuho commented Aug 6, 2019

Merging to unblock all CI panics.

@gyuho gyuho merged commit a996a8a into etcd-io:master Aug 6, 2019
@gyuho gyuho deleted the grpc branch August 6, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants