Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

functional: update go.etcd.io/etcd link and go image registry for func… #10987

Merged
merged 1 commit into from
Aug 6, 2019
Merged

functional: update go.etcd.io/etcd link and go image registry for func… #10987

merged 1 commit into from
Aug 6, 2019

Conversation

wenjiaswe
Copy link
Contributor

@wenjiaswe wenjiaswe commented Aug 6, 2019 •
edited
Loading

Fix some bugs when running functional docker test:

  1. update "go.etcd.io/etcd" link in functional/scripts
  2. update go image registry to match

    etcd/Makefile

    Line 493 in 4bf5848

    --tag gcr.io/etcd-development/etcd-functional:go$(GO_VERSION) \

I will backport to release-3.4 once merged.

@gyuho
Copy link
Contributor

gyuho commented Aug 6, 2019

thanks

@gyuho gyuho merged commit 44a00a3 into etcd-io:master Aug 6, 2019
@wenjiaswe wenjiaswe mentioned this pull request Aug 6, 2019
Merged
gyuho added a commit that referenced this pull request Aug 6, 2019
@gyuho
Merge pull request #10988 from wenjiaswe/automated-cherry-pick-of-#10…
e09528a 
…987-upstream-release-3.4

Automated cherry pick of #10987
@wenjiaswe wenjiaswe deleted the functional-test-fix branch October 15, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenjiaswe @gyuho