Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: path changes for moving to github/etcd-io/etcd #10060

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

vimalk78
Copy link
Contributor

@vimalk78 vimalk78 commented Sep 3, 2018

@xiang90
Copy link
Contributor

xiang90 commented Sep 3, 2018

lgtm

Copy link
Contributor

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @vimalk78!

@vimalk78 vimalk78 closed this Sep 3, 2018
@vimalk78 vimalk78 reopened this Sep 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #10060 into master will increase coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #10060     +/-   ##
=========================================
+ Coverage   71.32%   71.72%   +0.4%     
=========================================
  Files         390      390             
  Lines       36258    36258             
=========================================
+ Hits        25860    26006    +146     
+ Misses       8584     8448    -136     
+ Partials     1814     1804     -10
Impacted Files Coverage Δ
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
clientv3/balancer/balancer.go 84.49% <0%> (-2.33%) ⬇️
raft/node.go 90.98% <0%> (-1.57%) ⬇️
etcdctl/ctlv3/command/printer_simple.go 72.48% <0%> (-1.35%) ⬇️
clientv3/retry_interceptor.go 65.78% <0%> (-1.06%) ⬇️
etcdserver/cluster_util.go 58.74% <0%> (-0.9%) ⬇️
etcdserver/raft.go 80.09% <0%> (-0.72%) ⬇️
etcdserver/server.go 74.31% <0%> (+0.14%) ⬆️
clientv3/balancer/grpc1.7-health.go 59.3% <0%> (+0.29%) ⬆️
clientv3/watch.go 92.35% <0%> (+0.42%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca7dc4f...bcde798. Read the comment docs.

@xiang90 xiang90 merged commit 6143c13 into etcd-io:master Sep 3, 2018
wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants