Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildtags #879

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Update buildtags #879

merged 1 commit into from
Dec 31, 2024

Conversation

philoserf
Copy link
Contributor

Update build tags via go fix

@k8s-ci-robot
Copy link

Hi @philoserf. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Mark Ayers <[email protected]>
@ivanvc
Copy link
Member

ivanvc commented Dec 30, 2024

/ok-to-test

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified that go fix removes these comments. Thanks for your first contribution, @philoserf!

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

It would be better if we can improve the workflow check to automatically detect & fix such case.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, philoserf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 5da13a9 into etcd-io:main Dec 31, 2024
17 checks passed
@ivanvc
Copy link
Member

ivanvc commented Dec 31, 2024

Thanks.

It would be better if we can improve the workflow check to automatically detect & fix such case.

I agree. I was thinking something like what we have in the etcd repository and introducing a verify make target that runs the static checks.

@philoserf philoserf deleted the go-fix-fixes branch January 10, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants