Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go toolchain to 1.23.3 #856

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

samuelbartels20
Copy link
Contributor

[email protected]>
Please review

@k8s-ci-robot
Copy link

Hi @samuelbartels20. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@henrybear327
Copy link
Contributor

@samuelbartels20 please update the PR title :) Thanks!

@samuelbartels20
Copy link
Contributor Author

@samuelbartels20 please update the PR title :) Thanks!

@henrybear327 Please i don't understand. Could you please elaborate what you mean?

@ivanvc
Copy link
Member

ivanvc commented Nov 10, 2024

/ok-to-test
/retitle Bump go toolchain to 1.23.3

@k8s-ci-robot k8s-ci-robot changed the title Bump go toolchain to 1.23.3 Signed-off-by: Samuel Bartels <bartelssam… Bump go toolchain to 1.23.3 Nov 10, 2024
@ivanvc
Copy link
Member

ivanvc commented Nov 10, 2024

Link to etcd-io/etcd#18847

@henrybear327
Copy link
Contributor

@samuelbartels20 please update the PR title :) Thanks!

@henrybear327 Please i don't understand. Could you please elaborate what you mean?

Sorry that I just saw your message.

It's done by @ivanvc already!

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @samuelbartels20

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, samuelbartels20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 6bf3990 into etcd-io:main Nov 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants