Structuration import GTFS en batch job + dashboard de reporting #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbar
commented
Jan 14, 2023
thbar
commented
Jan 14, 2023
thbar
commented
Jan 14, 2023
| try do | ||
| data_import_id = Transport.GTFSImportStops.import_stops_and_remove_previous(rh.id) | ||
| %{resource_history_id: rh.id, status: :ok, data_import_id: data_import_id} | ||
| rescue |
There was a problem hiding this comment.
En cas d'erreur, je constitue une map précise pour afficher des choses dans le backoffice et faire en sorte d'itérer sur les imports.
apps/transport/test/transport/jobs/gtfs_import_stops_job_test.exs
Outdated
Show resolved
Hide resolved
apps/transport/lib/transport_web/live/backoffice/data_import_batch_report_live.ex
Outdated
Show resolved
Hide resolved
apps/transport/lib/transport_web/templates/backoffice/page/index.html.heex
Show resolved
Hide resolved
…atch_report_live.ex Co-authored-by: Antoine Augusti <[email protected]>
Co-authored-by: Antoine Augusti <[email protected]>
|
@AntoineAugusti j'ai pris en compte des comm, merci! |
AntoineAugusti
approved these changes
Jan 16, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dans cette PR, j'ajoute un job
GTFSImportStopsJobqui va rafraichir (viaTransport.GTFSImportStops.import_stops_and_remove_previous) tous les GTFS importés en base (gtfs_stops) et importer ceux qui ne le sont pas déjà.Le résultat est tracé dans une nouvelle table
data_import_batchsous forme demapsimplifiée.Le job peut être lancé depuis le back office avec un bouton.
Le résultat est affiché au même endroit (la vue prend le
DB.DataImportBatchle plus récent).Le résultat de consolidation est affiché de façon triée, pour grouper un peu les erreurs par "type d'erreur" et faciliter le travail de traitement de ces erreurs dans les prochaines PR.