Cast min_mapq to str instead of bytes #912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've been evaluating cnvkit for our data and overall liking it - results are looking good! However I've been noticing that the
--min-mapq
parameter doesn't seem to be propagating through correctly, and believe that this one-line change would be a fix.To replicate the issue using data already present in this repo, you can pull out this single read with MAPQ=33 into a mini bam:
And then run
cnvkit.py coverage
with two different thresholds, which yield identical .cnn files despite falling above and below the MAPQ of this read:And poking around more in the python, here's how using
str
instead ofbytes
is fixing the behavior:Thank you, and let me know if I've misunderstood something!