Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split build steps #70

Merged
merged 6 commits into from
Jun 14, 2020
Merged

Split build steps #70

merged 6 commits into from
Jun 14, 2020

Conversation

Et7f3
Copy link
Contributor

@Et7f3 Et7f3 commented Jun 12, 2020

It was first a response to: #66 (comment) And I have added some explanations why we use low-level command.

@Et7f3 Et7f3 force-pushed the split_build_steps branch from c32a4be to 6114f6b Compare June 13, 2020 06:52
@Et7f3
Copy link
Contributor Author

Et7f3 commented Jun 13, 2020

ping @ulrikstrid

Copy link
Collaborator

@ulrikstrid ulrikstrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we could use macos-latest but I don't think that should block this PR from landing. Thank you!

@ulrikstrid ulrikstrid merged commit 903f528 into esy-ocaml:master Jun 14, 2020
@Et7f3 Et7f3 deleted the split_build_steps branch June 14, 2020 14:03
Et7f3 added a commit to Et7f3/hello-reason that referenced this pull request Sep 5, 2020
* ci(deps): Use new shiny actions/github-script@v2

* uses: actions/[email protected]

* uses: actions/[email protected]

* ci: Split the build step and comment it.

* vmImage: macOS-10.14

* vmImage: macOS-10.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants