dekaf: Fix endpoint config parsing #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got left out of #1793 and is needed for Dekaf materialization endpoints
psFried
approved these changes
Dec 18, 2024
| @@ -70,8 +71,22 @@ pub async fn unary_materialize( | |||
| ) -> anyhow::Result<materialize::Response> { | |||
| use proto_flow::materialize::response::validated; | |||
| if let Some(mut validate) = request.validate { | |||
| serde_json::de::from_str::<DekafConfig>(&validate.config_json) | |||
| .context("validating endpoint config")?; | |||
| match materialization_spec::ConnectorType::try_from(validate.connector_type)? { | |||
There was a problem hiding this comment.
Just as an fyi, you could also use
let ConnectorType::Dekaf = ConnectorType::try_from(validate.connector_type)? else {
bail!("...");
};There was a problem hiding this comment.
But then I wouldn't have the parsed proto_flow::flow::materialization_spec::ConnectorType, which can give me a human-readableas_str_name() instead of just proto_flow::materialize::request::Validate:: connector_type: i32, which is much less useful in an error
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got left out of #1793 and is needed for Dekaf materialization endpoints
This change is