dekaf: Set _meta/is_deleted when deletions: CDC is set, even if collection schema has additionalProperties: true
#1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a has `additionalProperties: true` Had to switch from `Shape::widen()` to manually adding the location as if the collection schema has `additionalProperties: true` (or unset), `Shape::widen()` will be a no-op.
jshearer
force-pushed
the
jshearer/dekaf_cdc_deletions_without_schema_inference
branch
from
c8ed6b9 to
24e4ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Had to switch from
Shape::widen()to manually adding the location as if the collection schema hasadditionalProperties: true(or unset),Shape::widen()will be a no-op.This change is