Linting tweaks and updates #81
Conversation
…unignore `.eslintrc.js`;
use "js" extension for comments; enforce `semi` rule; lint `parser.js` to catch any buggy generator issues
- Linting (package.json): Add recommended fields (contributors, bugs, homepage); update repository URL
- Refactoring: Fix broken or redundant HTML
- Maintenance: Enforce 2 sp. for JSON in `.editorconfig` (per current `package.json`)
- npm: Add build scripts (leading currently to Makefile)
|
Btw, previous to my HTML tweaks, the runner seems broken anyways, as it only indicates 0/0 tests running. |
|
I think it's about time that we drop the old node support, but it would've been nice to call that out in the PR description. |
.eslintrc.js
Outdated
| overrides: [{ | ||
| files: 'parser.js', | ||
| rules: { | ||
| // We could disable checking as auto-generated |
There was a problem hiding this comment.
Yes just ignore the generated file(s).
There was a problem hiding this comment.
Ok, sure. I personally like to check, albeit without applying mere formatting rules, since one doesn't know if a dependency did its own linting, especially in such a case as this where the code to lint was generated at our calling, rather than being bundled with the dependency. But it was safe when checked. :)
IMHO, linting normal dependencies is also a good idea (though I haven't done that here no less because eslint does not, unforutnately imo, allow linting of node_modules even with ignore overrides). I think this would be even more compelling of a use case than checking one's own code to find not only bugs but unwanted privileged module/API use if the linting is robust enough (e.g., preventing or checking dynamic access to require, setting of global, etc.), but again this is not supported anyways.
- Refactoring: remove now unneeded `Array.isArray` polyfill - npm: Update estraverse dep. minor version and devDeps.
|
My apologies re: the breaking change not having been listed. I think I originally just thought I was tacking on some minor changes, especially with the I've now added it to the main description as follows, along with another line item not previously mentioned (also added later because of the update):
|
estraverse)Array.isArraypolyfillnode_modulesanddistto ignore file and unignore.eslintrc.js;use "js" extension (besides succincter syntax, allows comments); enforce
semirule; lint
parser.js(disabling some rules) to catch any buggy generator issuespackage.json): Add recommended fields (contributors,bugs,homepage);update repository URL
.editorconfig(per currentpackage.json)Makefile)estraversedep. minor version and devDeps..travis.yml: Slightly simpler syntax