Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 506 #529

Merged
merged 7 commits into from
Nov 22, 2021
Merged

Issue 506 #529

merged 7 commits into from
Nov 22, 2021

Conversation

eugenwintersberger
Copy link
Collaborator

The tests should run. Can anyone may have a look on the Jenkins setup. Somehow I am too stupid to get a new container running.

@eugenwintersberger eugenwintersberger self-assigned this Nov 20, 2021
@jkotan
Copy link
Collaborator

jkotan commented Nov 20, 2021

Your conanfile_1.12.0.txt should look like conanfile_ess.txt (used for deb10) with replaced hdf5/1.10.6 by hdf5/1.12.0 .
Then it works.

@jkotan
Copy link
Collaborator

jkotan commented Nov 22, 2021

I've just updated the conanfile in your PR.

jkotan
jkotan approved these changes Nov 22, 2021
View reviewed changes
Copy link
Collaborator

@jkotan jkotan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good to me.

@eugenwintersberger
Copy link
Collaborator Author

Ah. Thanks a lot. I will do the merge.

@eugenwintersberger eugenwintersberger merged commit 4f25463 into master Nov 22, 2021
@jkotan jkotan deleted the issue_506 branch November 23, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotan jkotan jkotan approved these changes

@matthew-d-jones matthew-d-jones Awaiting requested review from matthew-d-jones

Assignees

@eugenwintersberger eugenwintersberger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eugenwintersberger @jkotan