Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/cmd echo file #21

Merged
merged 1 commit into from
May 19, 2021
Merged

Bugfix/cmd echo file #21

merged 1 commit into from
May 19, 2021

Conversation

georgik
Copy link
Collaborator

@georgik georgik commented May 19, 2021

Check whether file "echo." exists when launching CMD.
Rename the file to echo.old to avoid problems with collision of "echo." command.

Closes #20

Copy link
Collaborator

@kumekay kumekay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the issue, thank you, Juraj

Is there a chance that some other built-in functions will be shadowed?

@georgik georgik merged commit 1409236 into test/release-2.9 May 19, 2021
georgik added a commit that referenced this pull request Jun 16, 2021
* tools: display error in case of ESP-IDF path longer than 90 characters (#16)
* tools: display error in case of ESP-IDF and Tools path longer than 90 characters
* tools: add checkbox with PowerShell and CMD launcher to the end of installation process (#17)
* tools: CMD initializer rename echo. file (#21)
* tools: add Windows Terminal dropdown menu registration for ESP-IDF (#22)
* tools: Offline installer ESP-IDFv4.3
* tools: update missing Python wheels for Offline installation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants