Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine reset sequence constructor functions #181

Merged

Conversation

makermelissa
Copy link
Contributor

Description

This combines the Reset Sequence construction functions so the no_reset mode actually doesn't reset.

Related

Supersedes #179
#146

Testing

Same as #179 testing.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@brianignacio5 brianignacio5 merged commit 24fd283 into espressif:feature/reset-modes Jan 13, 2025
@brianignacio5 brianignacio5 mentioned this pull request Jan 13, 2025
brianignacio5 added a commit that referenced this pull request Jan 14, 2025
* add before after reset modes

* Combine reset sequence constructor functions (#181)

* update pages node version rm duplicate debug msg

* add after hard reset in live demo

---------

Co-authored-by: Melissa LeBlanc-Williams <[email protected]>
brianignacio5 added a commit that referenced this pull request Jan 14, 2025
* add before after reset modes

* Combine reset sequence constructor functions (#181)

* update pages node version rm duplicate debug msg

* add after hard reset in live demo

---------

Co-authored-by: Melissa LeBlanc-Williams <[email protected]>

npm audit

test pages

use ubuntu 20

update pages yml

add parcel workers 0

parcel build workers

rm debug action

update action version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants