Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Chrome on Android with web-serial-polyfill in the Example Pages. #144

Merged
merged 1 commit into from
May 31, 2024

Conversation

Lan-Hekary
Copy link
Contributor

Add Google Chrome on Android version 61 or later via the web-serial-polyfill compatibility layer.

I tested it and it works as expected with Chrome on Android Phones and Tablets.

@brianignacio5 brianignacio5 linked an issue May 31, 2024 that may be closed by this pull request
@brianignacio5
Copy link
Collaborator

LGTM thanks for your contribution

@brianignacio5 brianignacio5 merged commit 265ece5 into espressif:main May 31, 2024
1 check passed
@Lan-Hekary
Copy link
Contributor Author

Lan-Hekary commented Jun 3, 2024

Thanks @brianignacio5 ,
Thanks for the merge, it's working as expected.
I Just realized that I can use the package from the CDN(JSDeliver or unpkg) instead of putting it in the package.json file and bundle it with the site assets.
I don't know if it is the right way to import external modules (Import from CDN or Bulid and bundle it with the site), I'd love to hear you opinion on the matter.
If you want me to make this change too, I can make it
It's more aligned with the current codebase and won't affect the functionality.

@Lan-Hekary Lan-Hekary deleted the android-support branch June 3, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make esptool-js available on Android device.
2 participants