Re-add original SD FAT info access methods #6092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes esp8266#6081 The SD rewrite blanked out some of the internal FAT info.. Restore the function calls and return proper values.
d-a-v
approved these changes
May 14, 2019
There was a problem hiding this comment.
@luc-github mentionned the fact that size() is limited to 4GB.
I am not a SD specialist (SDHC, SDXC, SDwhatever w/ MMC protocol),
and I know little about SdFat compatibility with them.
Approving since it restores the old behaviour, maybe a new issue needs to be opened about bigger cards.
devyte
requested changes
May 15, 2019
Support reporting proper size for >4GB SD cards.
Because size() is used in many printf()s, we can't just change its return type to uint64. Instead, when size is > size-max, return size-max. Add size64 which can be used by new apps who care about >4GB cards.
|
Actually, can't change size() to return 64b, it breaks printf() and other existing apps. Added the size64() (which I think we're going to have for FS)... |
devyte
requested changes
May 15, 2019
earlephilhower
force-pushed
the
sd-fat-access
branch
from
eed7cab to
909a93f
Compare
devyte
requested changes
May 18, 2019
|
Debug output shown w/a blank 32GB card: |
devyte
approved these changes
May 18, 2019
earlephilhower
added a commit
to earlephilhower/Arduino
that referenced
this pull request
May 20, 2019
Changes since 2.5.1 (to 2.5.2) Core ---- * Add explicit Print::write(char) (esp8266#6101) Build system ---- * Fix typo in elf2bin for QOUT binary generation (esp8266#6116) * Support PIO Wl-T and Arduino -T linking properly (esp8266#6095) * Allow *.cc files to be linked into flash by default (esp8266#6100) * Use custom "ElfToBin" builder for PIO (esp8266#6091) * Fail if generated JSON file cannot be read (esp8266#6076) * Moved 'Dropping' print from stdout to stderr in drop_versions.py (esp8266#6071) * Fix PIO issue when build environment contains spaces (esp8266#6119) Libraries ---- * Remove deadlock when server is not acking our data (esp8266#6107) * Bugfix for stuck in write method of WiFiClient and WiFiClientSecure until the remote peer closed connection (esp8266#6104) * Re-add original SD FAT info access methods (esp8266#6092) * Make FILE_WRITE append in SD.h wrapper (esp8266#6106) * Drop X509 after connection, avoid hang on TLS broken (esp8266#6065)
Merged
earlephilhower
added a commit
that referenced
this pull request
May 20, 2019
Changes since 2.5.1 (to 2.5.2) Core ---- * Add explicit Print::write(char) (#6101) Build system ---- * Fix typo in elf2bin for QOUT binary generation (#6116) * Support PIO Wl-T and Arduino -T linking properly (#6095) * Allow *.cc files to be linked into flash by default (#6100) * Use custom "ElfToBin" builder for PIO (#6091) * Fail if generated JSON file cannot be read (#6076) * Moved 'Dropping' print from stdout to stderr in drop_versions.py (#6071) * Fix PIO issue when build environment contains spaces (#6119) Libraries ---- * Remove deadlock when server is not acking our data (#6107) * Bugfix for stuck in write method of WiFiClient and WiFiClientSecure until the remote peer closed connection (#6104) * Re-add original SD FAT info access methods (#6092) * Make FILE_WRITE append in SD.h wrapper (#6106) * Drop X509 after connection, avoid hang on TLS broken (#6065)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6081
The SD rewrite blanked out some of the internal FAT info.. Restore the
function calls and return proper values.