Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on lazy_static in favour of built-in LazyLock #755

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

jessebraham
Copy link
Member

There has been a built-in solution for this problem in Rust for quite some time now, so no reason to depend on this package anymore.

@jessebraham jessebraham added the skip-changelog Skips the changelog CI check label Feb 10, 2025
@jessebraham jessebraham changed the title Remove the dependency on lazy_static in favour of buildt-in LazyLock Remove the dependency on lazy_static in favour of built-in LazyLock Feb 10, 2025
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, shall we add a changelog entry about removing the lazy_static dependency?

@jessebraham
Copy link
Member Author

The change is invisible to the user, it was behind the cli feature anyway which is not stable.

@jessebraham jessebraham added this pull request to the merge queue Feb 10, 2025
Merged via the queue into esp-rs:main with commit ad1cb9f Feb 10, 2025
25 checks passed
@jessebraham jessebraham deleted the fixes/lazy-static branch February 11, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips the changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants